Rename TimeZoneTimeProvider to RequestTimeProvider for better clarity and consistency#32
Merged
marcominerva merged 2 commits intomasterfrom Oct 8, 2025
Conversation
…ll references Co-authored-by: marcominerva <3522534+marcominerva@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Rename TimeZoneTimeProvider class to RequestTimeProvider and update related variables
Rename TimeZoneTimeProvider to RequestTimeProvider for better clarity and consistency
Sep 26, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the codebase by renaming TimeZoneTimeProvider to RequestTimeProvider to better reflect its purpose of providing timezone-aware time information based on HTTP request context. The change improves code readability and maintains consistency throughout the application.
- Renamed the core time provider class and updated all references
- Updated dependency injection registration in the main application setup
- Synchronized variable naming conventions across all template engines
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/PdfSmith/Program.cs | Updated DI registration to use the new RequestTimeProvider class name |
| src/PdfSmith.BusinessLayer/Services/RequestTimeProvider.cs | Renamed the main class from TimeZoneTimeProvider to RequestTimeProvider |
| src/PdfSmith.BusinessLayer/Templating/ScribanTemplateEngine.cs | Updated constructor parameter and usage to use requestTimeProvider variable naming |
| src/PdfSmith.BusinessLayer/Templating/RazorTemplateEngine.cs | Updated @Inject directive and template replacement patterns to use new class and variable names |
| src/PdfSmith.BusinessLayer/Templating/HandlebarsTemplateEngine.cs | Updated constructor parameter and all internal references to use requestTimeProvider naming |
marcominerva
requested changes
Sep 26, 2025
marcominerva
approved these changes
Sep 26, 2025
marcominerva
deleted the
copilot/fix-6a591574-dc6f-4ffe-b0a9-5ef54ad9ddb6
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames the
TimeZoneTimeProviderclass toRequestTimeProviderto improve code readability and better reflect its purpose. The class is primarily used to provide timezone-aware time information based on HTTP request context, making "RequestTimeProvider" a more descriptive and intuitive name.Changes Made
TimeZoneTimeProvider→RequestTimeProviderTimeZoneTimeProvider.cs→RequestTimeProvider.csProgram.csto register the renamed classHandlebarsTemplateEngine,ScribanTemplateEngine,RazorTemplateEngine) to use the new class nametimeZoneTimeProvidertorequestTimeProviderthroughout the codebase for consistency@injectdirective inRazorTemplateEngineto reference the new class and variable namesBenefits
All existing functionality remains unchanged - this is purely a refactoring change to improve code quality and readability.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.